Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delay crc-detection and init till after activation #218

Merged
merged 1 commit into from
May 20, 2024
Merged

fix: delay crc-detection and init till after activation #218

merged 1 commit into from
May 20, 2024

Conversation

dgolovin
Copy link
Contributor

Fix #211.

main ↪️ Activating extension (redhat.openshift-local) with max activation time of 20 seconds
VM5:62 main ↪️ Activating extension (redhat.openshift-local) ended in 11 milliseconds

@dgolovin dgolovin requested review from gbraad, benoitf and jeffmaury May 15, 2024 02:49
jeffmaury
jeffmaury approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgolovin dgolovin merged commit e783c71 into crc-org:main May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

@gbraad gbraad Awaiting requested review from gbraad

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] OpenShift Local Extension activation timed out after 10s
2 participants
@dgolovin @jeffmaury